view src/g23m-aci/aci/gaci_cmd.h @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  GPRS Command handler interface definitions.
+----------------------------------------------------------------------------- 
*/ 

/* needs: aci_cmd.h */

#ifndef GACI_CMD_H
#define GACI_CMD_H

/* sub structure concerning AT+CGREG and
AT%CGREG command in ATI */

typedef struct
{
  T_ATI_REG_MOD_LAC_CID mod_lac_cid;
  T_CGREG_STAT          last_presented_state;
} T_ATI_CGREG;

typedef struct
{
  T_ATI_REG_MOD_LAC_CID mod_lac_cid;
  T_P_CGREG_STAT        last_presented_state;
} T_ATI_P_CGREG;

typedef struct
{
  T_ATI_CGREG    plus_cgreg;
  T_ATI_P_CGREG  percent_cgreg;

} T_ATI_GPRS_USER_OUTPUT_CFG;


EXTERN void gaci_ati_cmd_init_each_source( UBYTE srcId );


#ifdef ACI_CMD_C
/* next variable is aimed at containing the user defined configuration
for the output format through AT interpreter for GPRS */
GLOBAL T_ATI_GPRS_USER_OUTPUT_CFG ati_gprs_user_output_cfg[CMD_SRC_MAX];

#else /* ACI_CMD_C */

EXTERN T_ATI_GPRS_USER_OUTPUT_CFG ati_gprs_user_output_cfg[CMD_SRC_MAX];
#endif /* ACI_CMD_C */


#endif /* GACI_CMD_H */
/*==== EOF ========================================================*/