FreeCalypso > hg > fc-tourmaline
view src/g23m-aci/aci/psa_util.h @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | fa8dc04885d8 |
| children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-PS (6147) | Modul : PSA_UTIL +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Definitions for the PSA utility functions. +----------------------------------------------------------------------------- */ #ifndef PSA_UTIL_H #define PSA_UTIL_H /*==== CONSTANTS ==================================================*/ /*==== TYPES ======================================================*/ /*==== PROTOTYPES =================================================*/ EXTERN void utl_BCD2String (char *bcd_string, const UBYTE *bcd, USHORT len); EXTERN USHORT utl_dialStr2BCD (const char *pDialStr, UBYTE *pBCDBuf, UBYTE maxDigits); EXTERN void utl_BCD2DialStr (const UBYTE *pBCD, char *pDSBuf, UBYTE numDigits); /* PATCH Add bit_offset parameter to function cvt7To8 */ /*EXTERN UBYTE utl_cvt7To8 ( UBYTE* source, UBYTE source_len, UBYTE* dest );*/ EXTERN UBYTE utl_cvt7To8 ( const UBYTE* source, UBYTE source_len, UBYTE* dest, UBYTE bit_offset); /* PATCH END */ EXTERN UBYTE utl_cvtPnn7To8 (const UBYTE* source, UBYTE source_len, UBYTE dcs, UBYTE* dest ); EXTERN UBYTE utl_cvt8To7 ( const UBYTE* source, UBYTE source_len, UBYTE* dest, UBYTE bit_offset); /* Implements Measure 25 */ #ifdef FF_SAT_E EXTERN T_ACI_CMD_SRC psa_search_SATSrcId (void); #endif /* FF_SAT_E */ /*==== EXPORT =====================================================*/ #endif /* PSA_UTIL_H */ /*==== EOF =======================================================*/