view src/g23m-fad/app/bat_cfg.h @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/*
+-----------------------------------------------------------------------------
|  Project :  GSM-F&D (8411)
|  Modul   :  BAT library
+-----------------------------------------------------------------------------
|  Copyright 2005 Texas Instruments Berlin, AG
|                 All rights reserved.
|
|                 This file is confidential and a trade secret of Texas
|                 Instruments Berlin, AG
|                 The receipt of or possession of this file does not convey
|                 any rights to reproduce or disclose its contents or to
|                 manufacture, use, or sell anything it may describe, in
|                 whole, or in part, without the specific written consent of
|                 Texas Instruments Berlin, AG.
+-----------------------------------------------------------------------------
|  Purpose :  configuration for binary AT commands
+-----------------------------------------------------------------------------
*/
#ifndef BAT_CFG_H
#define BAT_CFG_H

#include "typedefs.h"   /* to include some defined types */
#include "l2p_types.h"
#include "gdd.h"


/*********************************************************************************
 *
 * defines
 *
 *********************************************************************************/

#define L2P_MAINTAIN_SIZE L2P_CONTROL_BLOCK_HDR_SIZE


/*********************************************************************************
 *
 * enumerations
 *
 *********************************************************************************/

typedef enum
{
  DEVICE_PACKET = 0
  /*more to be defined*/
}T_BAT_device;


/*********************************************************************************
 *
 * A description of the GDD interface
 *
 *********************************************************************************/

typedef struct
{
  T_GDD_FUNC                gdd_if; 
  T_GDD_CAP                 cap;
}T_BAT_adapter;


/*********************************************************************************
 *
 * A description of the L2P protocol Id
 *
 *********************************************************************************/

typedef struct
{
  T_L2P_SUPPORTED_PROTOCOLS protocol_id;
}T_BAT_l2p;

typedef struct
{
  T_BAT_device              device;
  T_BAT_adapter             adapter;
  T_BAT_l2p                 l2p;
}T_BAT_config;


/*********************************************************************************
 *
 * with this release the following configuration data should be used
 *
 *********************************************************************************/


extern T_BAT_config *BAT_APP_CONFIG;
void app_set_config (void);


#endif /* BAT_CFG_H */