FreeCalypso > hg > fc-tourmaline
view src/g23m-fad/ppp/ppp_onaf.c @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : | Modul : +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This modul is part of the entity PPP and implements all | procedures and functions as described in the | SDL-documentation (ONA-statemachine) +----------------------------------------------------------------------------- */ #ifndef PPP_ONAF_C #define PPP_ONAF_C #endif /* !PPP_ONAF_C */ #define ENTITY_PPP /*==== INCLUDES =============================================================*/ #include "typedefs.h" /* to get Condat data types */ #include "vsi.h" /* to get a lot of macros */ #include "macdef.h" /* to get a lot of macros */ #include "custom.h" /* to get a lot of macros */ #include "gsm.h" /* to get a lot of macros */ #include "cnf_ppp.h" /* to get cnf-definitions */ #include "mon_ppp.h" /* to get mon-definitions */ #include "prim.h" /* to get the definitions of used SAP and directions */ #include "dti.h" /* to get the DTILIB definitions */ #include "ppp.h" /* to get the global entity definitions */ /*==== CONST ================================================================*/ /*==== LOCAL VARS ===========================================================*/ /*==== PRIVATE FUNCTIONS ====================================================*/ /*==== PUBLIC FUNCTIONS =====================================================*/ /* +------------------------------------------------------------------------------ | Function : ona_init +------------------------------------------------------------------------------ | Description : The function ona_init() initializes the option negotiation | automaton (ONA) | | Parameters : no parameters | +------------------------------------------------------------------------------ */ GLOBAL void ona_init () { UBYTE i; TRACE_FUNCTION( "ona_init" ); for (i = 0;i < ONA_NUM_INC;i++) { ppp_data->ona = & ppp_data->ona_base[i]; /* counter for Configure-Request and Terminate-Request sent */ ppp_data->ona->restarts = 0; /* counter for Configure-Nak and Configure-Reject sent */ ppp_data->ona->failures = 0; /* * counter for Configure-Ack received * this counter avoids endless loops where the PPP peer always answers with * a Configure-Ack, but it does not send a Configure-Req */ ppp_data->ona->loops = 0; INIT_STATE( PPP_SERVICE_ONA , ONA_CLOSED ); } } /* ona_init() */ /* +------------------------------------------------------------------------------ | Function : ona_get_inst_index +------------------------------------------------------------------------------ | Description : gets the index (0, 1) for the given ptype (DTI_PID_LCP, | DTI_PID_IPCP). This function is used when a calling service serves a key for | one of the 2 possible instances of services LCR and NCR. | | Parameters : USHORT ptype, UBYTE* index | +------------------------------------------------------------------------------ */ GLOBAL void ona_get_inst_index(USHORT ptype, UBYTE* index) { TRACE_FUNCTION("ona_get_inst_index"); if (ptype EQ DTI_PID_LCP) { *index = 0; } else if (ptype EQ DTI_PID_IPCP) { *index = 1; } else { TRACE_ERROR( "ONA_GET_INST_INDEX unexpected ptype" ); *index = 0; } }