FreeCalypso > hg > fc-tourmaline
view src/g23m-fad/tcpip/rnet.c @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/*--------------------------------------------------------------------------- * Adaption of Riviera Net (RNET) TCP/IP to GPF and DTI2 *-------------------------------------------------------------------------*/ /* Here we define some dummy Riviera Frame functions * so that we can link an executable, * only to be sure that we've copied all we need. */ /*-------------------------------------------------------------------------*/ #include "rnet.h" /*-------------------------------------------------------------------------*/ #include "atp_cmd.h" /* from /ti/release/ti_5.4.0_p1/code/services/atp/atp_sw_ent.c */ T_ATP_RET atp_reg ( T_ATP_SW_ENTITY_NAME name, T_ATP_CALLBACK return_path, T_ATP_ENTITY_MODE mode , T_ATP_SW_ENTITY_ID * sw_id_p ) { return RV_OK; } T_ATP_RET atp_dereg (T_ATP_SW_ENTITY_ID sw_id) { return RV_OK; } /*-------------------------------------------------------------------------*/ /* from /ti/release/ti_5.4.0_p1/code/services/atp/atp_services.c */ T_ATP_RET atp_send_data ( T_ATP_SW_ENTITY_ID sender_sw_id, T_ATP_PORT_NB sender_port_nb, void * data_buffer_p, UINT32 buffer_size, UINT32 * nb_bytes_left_p ) { return RV_OK; } T_ATP_RET atp_get_data ( T_ATP_SW_ENTITY_ID receiver_sw_id, T_ATP_PORT_NB receiver_port_nb, UINT8 * data_buffer, UINT32 nb_to_read, UINT32 * nb_read_p, UINT32 * nb_left_p ) { return RV_OK; } T_ATP_RET atp_open_port_rsp ( T_ATP_SW_ENTITY_ID initiator_id, T_ATP_PORT_NB initiator_port_nb, T_ATP_SW_ENTITY_ID target_id, T_ATP_PORT_NB target_port_nb, T_ATP_PORT_INFO port_info, T_ATP_NO_COPY_INFO no_copy_info, T_ATP_CUSTOM_INFO * custom_info_p, T_ATP_OPEN_PORT_RESULT result ) { return RV_OK; } T_ATP_RET atp_free_buffer (void * buffer_p) { return RV_OK; }