mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.

/*
 * This C module is a reconstruction based on the disassembly of
 * os_drv.obj in frame_na7_db_fl.lib from the Leonardo package.
 */

/* set of included headers from COFF symtab: */
#include "nucleus.h"
#include "typedefs.h"
#include "gdi.h"
#include "os.h"

typedef unsigned char u_char;

extern OS_HANDLE os_ext_pool_handle;

static u_char *HISR_Stack;
static T_DRV_SIGNAL *SignalID;
static void (*DrvCallback)(T_DRV_SIGNAL *);
static NU_HISR CallBack_HISR;

#define	CB_HISR_STACK_SIZE	1024

GLOBAL LONG
os_ExecuteCallback(OS_HANDLE Caller, void (*Callback)(T_DRV_SIGNAL *),
			T_DRV_SIGNAL *Signal)
{
	DrvCallback = Callback;
	SignalID = Signal;
	NU_Activate_HISR(&CallBack_HISR);
	return(OS_OK);
}

static void
CallbackFunc(void)
{
	DrvCallback(SignalID);
}

GLOBAL LONG
os_CreateCallback(void)
{
	if (os_AllocateMemory(OS_NOTASK, (T_VOID_STRUCT **) &HISR_Stack,
				CB_HISR_STACK_SIZE, 0xFFFFFFFF,
				os_ext_pool_handle) == OS_ERROR)
		return(OS_ERROR);
	if (NU_Create_HISR(&CallBack_HISR, "CB_HISR", CallbackFunc, 2,
				HISR_Stack, CB_HISR_STACK_SIZE) == NU_SUCCESS)
		return(OS_OK);
	else
		return(OS_ERROR);
}