FreeCalypso > hg > fc-tourmaline
view src/nucleus/cs_extr.h @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/*************************************************************************/ /* */ /* Copyright Mentor Graphics Corporation 2002 */ /* All Rights Reserved. */ /* */ /* THIS WORK CONTAINS TRADE SECRET AND PROPRIETARY INFORMATION WHICH IS */ /* THE PROPERTY OF MENTOR GRAPHICS CORPORATION OR ITS LICENSORS AND IS */ /* SUBJECT TO LICENSE TERMS. */ /* */ /*************************************************************************/ /*************************************************************************/ /* */ /* FILE NAME VERSION */ /* */ /* cs_extr.h Nucleus PLUS 1.14 */ /* */ /* COMPONENT */ /* */ /* CS - Common Services */ /* */ /* DESCRIPTION */ /* */ /* This file contains function prototypes of all functions */ /* accessible to other components. */ /* */ /* DATA STRUCTURES */ /* */ /* None */ /* */ /* FUNCTIONS */ /* */ /* None */ /* */ /* DEPENDENCIES */ /* */ /* cs_defs.h Common service definitions */ /* */ /* HISTORY */ /* */ /* DATE REMARKS */ /* */ /* 03-01-1993 Created initial version 1.0 */ /* 04-19-1993 Verified version 1.0 */ /* 03-01-1994 Moved include files outside of */ /* the file #ifndef to allow the */ /* use of actual data structures, */ /* added inline capability for */ /* linked-list functions, */ /* resulting in version 1.1 */ /* */ /* 03-18-1994 Verified version 1.1 */ /* 04-17-1996 updated to version 1.2 */ /* 02-02-1998 Corrected SPR347 where NU_INLINE */ /* created a linker error because */ /* CSC_Priority_Place_On_List was */ /* "extern"d instead of "VOID"d */ /* resulting in version 1.2a */ /* 03-24-1998 Released version 1.3. */ /* 03-26-1999 Released 1.11m (new release */ /* numbering scheme) */ /* 04-17-2002 Released version 1.13m */ /* 11-07-2002 Released version 1.14 */ /*************************************************************************/ #include "cs_defs.h" /* Include CS definitions */ /* Check to see if the file has been included already. */ #ifndef CS_EXTR #define CS_EXTR #ifndef NU_INLINE VOID CSC_Place_On_List(CS_NODE **head, CS_NODE *new_node); VOID CSC_Priority_Place_On_List(CS_NODE **head, CS_NODE *new_node); VOID CSC_Remove_From_List(CS_NODE **head, CS_NODE *node); #else #define CSC_Place_On_List(head, new_node); \ if (*((CS_NODE **) (head))) \ { \ ((CS_NODE *) (new_node)) -> cs_previous= \ (*((CS_NODE **) (head))) -> cs_previous; \ (((CS_NODE *) (new_node)) -> cs_previous) -> cs_next = \ (CS_NODE *) (new_node); \ ((CS_NODE *) (new_node)) -> cs_next = \ (*((CS_NODE **) (head))); \ (((CS_NODE *) (new_node)) -> cs_next) -> cs_previous = \ ((CS_NODE *) (new_node)); \ } \ else \ { \ (*((CS_NODE **) (head))) = ((CS_NODE *) (new_node)); \ ((CS_NODE *) (new_node)) -> cs_previous = \ ((CS_NODE *) (new_node)); \ ((CS_NODE *) (new_node)) -> cs_next = \ ((CS_NODE *) (new_node)); \ } VOID CSC_Priority_Place_On_List(CS_NODE **head, CS_NODE *new_node); #define CSC_Remove_From_List(head, node); \ if (((CS_NODE *) (node)) -> cs_previous == \ ((CS_NODE *) (node))) \ { \ (*((CS_NODE **) (head))) = NU_NULL; \ } \ else \ { \ (((CS_NODE *) (node)) -> cs_previous) -> cs_next = \ ((CS_NODE *) (node)) -> cs_next; \ (((CS_NODE *) (node)) -> cs_next) -> cs_previous = \ ((CS_NODE *) (node)) -> cs_previous; \ if (((CS_NODE *) (node)) == *((CS_NODE **) (head))) \ *((CS_NODE **) (head)) = \ ((CS_NODE *) (node)) -> cs_next; \ } #endif #endif