FreeCalypso > hg > fc-tourmaline
view src/nucleus/er_defs.h @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
#ifndef ER_DEFS_H #define ER_DEFS_H #ifdef NU_DEBUG_MEMORY /* NU_DEBUG_MEMORY can only service one memory pool each time it is compiled. It will examine the memory pool NU_DEBUG_POOL points to.*/ #define NU_DEBUG_POOL System_Memory typedef struct ER_DEBUG_ALLOCATION_STRUCT { /* prev is the link needed to maintain a linked list of all the ER_DEBUG_ALLOCATION structures. The head of the list is the global variable ERD_RecentAllocation. */ struct ER_DEBUG_ALLOCATION_STRUCT *prev; /* size is the number of bytes used for the users memory allocation */ unsigned int size; /* Assignes each allocation an unique ID */ unsigned long AllocSequenceCounter; /* line and file refer to the place in the code where the call to the allocation is made in the application. These variables are filled in with compiler specific macros. */ unsigned long line; const char * file; /* head and foot contain the non-null terminated strings "HEAD" and "FOOT" so this module can spot some instances where pointers write to memory locations beyond thier bounds. data is the user's data which the allocation call is intended. */ unsigned char head[4]; unsigned char data[1]; } ER_DEBUG_ALLOCATION; #endif /* NU_DEBUG_MEMORY */ #endif /* ER_DEFS_H */