FreeCalypso > hg > fc-tourmaline
view src/nucleus/eri.c @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/*************************************************************************/ /* */ /* Copyright Mentor Graphics Corporation 2002 */ /* All Rights Reserved. */ /* */ /* THIS WORK CONTAINS TRADE SECRET AND PROPRIETARY INFORMATION WHICH IS */ /* THE PROPERTY OF MENTOR GRAPHICS CORPORATION OR ITS LICENSORS AND IS */ /* SUBJECT TO LICENSE TERMS. */ /* */ /*************************************************************************/ /*************************************************************************/ /* */ /* FILE NAME VERSION */ /* */ /* eri.c Nucleus PLUS 1.14 */ /* */ /* COMPONENT */ /* */ /* ER - Error Management */ /* */ /* DESCRIPTION */ /* */ /* This file contains the initialization routine for the Error */ /* Management component. */ /* */ /* DATA STRUCTURES */ /* */ /* None */ /* */ /* FUNCTIONS */ /* */ /* ERI_Initialize Error Management Initialize */ /* */ /* DEPENDENCIES */ /* */ /* er_extr.h Error management interfaces */ /* */ /* HISTORY */ /* */ /* DATE REMARKS */ /* */ /* 03-01-1993 Created initial version 1.0 */ /* 04-19-1993 Verified version 1.0 */ /* 03-01-1994 Replaced void with VOID, */ /* resulting in version 1.1 */ /* */ /* 03-18-1994 Verified version 1.1 */ /* 04-17-1996 updated to version 1.2 */ /* 03-24-1998 Released version 1.3. */ /* 03-26-1999 Released 1.11m (new release */ /* numbering scheme) */ /* 04-07-1999 Release 1.11mA */ /* 04-17-2002 Released version 1.13m */ /* 11-07-2002 Released version 1.14 */ /*************************************************************************/ #define NU_SOURCE_FILE #include "er_extr.h" /* Error management interfaces */ #include "er_defs.h" /* Define inter-component global data references. */ extern INT ERD_Error_Code; #ifdef NU_DEBUG_MEMORY extern UINT32 ERD_AllocationCount; extern UINT32 ERD_AllocationSequenceCounter; extern UINT32 ERD_TotalMemoryAllocated; extern UINT32 ERD_TotalMemoryAllocations; extern UINT32 ERD_MaxTotalMemoryAllocated; extern UINT32 ERD_MaxTotalMemoryAllocations; extern ER_DEBUG_ALLOCATION *ERD_RecentAllocation; #endif /* NU_DEBUG_MEMORY */ #ifdef NU_DEBUG extern UNSIGNED ERD_Assert_Count; #endif #ifdef NU_ERROR_STRING extern CHAR ERD_Error_String[]; #endif /*************************************************************************/ /* */ /* FUNCTION */ /* */ /* ERI_Initialize */ /* */ /* DESCRIPTION */ /* */ /* This function initializes the data structures of the Error */ /* management component (ER). */ /* */ /* CALLED BY */ /* */ /* INC_Initialize System initialization */ /* */ /* CALLS */ /* */ /* None */ /* */ /* INPUTS */ /* */ /* None */ /* */ /* OUTPUTS */ /* */ /* ERD_Error_Code Contains system error code */ /* ERD_Error_String ASCII error code string */ /* */ /* HISTORY */ /* */ /* DATE REMARKS */ /* */ /* 03-01-1993 Created initial version 1.0 */ /* 04-19-1993 Verified version 1.0 */ /* 03-01-1994 Replaced void with VOID, */ /* resulting in version 1.1 */ /* */ /* 03-18-1994 Verified version 1.1 */ /* */ /*************************************************************************/ VOID ERI_Initialize(VOID) { /* Clear the system error code flag. */ ERD_Error_Code = 0; #ifdef NU_DEBUG_MEMORY /* Clear variables that help find memory problems */ ERD_AllocationCount = 0; ERD_AllocationSequenceCounter = 0; ERD_TotalMemoryAllocated = 0; ERD_TotalMemoryAllocations = 0; ERD_MaxTotalMemoryAllocated = 0; ERD_MaxTotalMemoryAllocations = 0; ERD_RecentAllocation = 0; #endif /* NU_DEBUG_MEMORY */ #ifdef NU_DEBUG /* Clear count of failed assertions. */ ERD_Assert_Count = 0; #endif #ifdef NU_ERROR_STRING /* Make the error string null. */ ERD_Error_String[0] = 0; #endif }