FreeCalypso > hg > fc-tourmaline
view src/nucleus/hi_defs.h @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/*************************************************************************/ /* */ /* Copyright Mentor Graphics Corporation 2002 */ /* All Rights Reserved. */ /* */ /* THIS WORK CONTAINS TRADE SECRET AND PROPRIETARY INFORMATION WHICH IS */ /* THE PROPERTY OF MENTOR GRAPHICS CORPORATION OR ITS LICENSORS AND IS */ /* SUBJECT TO LICENSE TERMS. */ /* */ /*************************************************************************/ /*************************************************************************/ /* */ /* FILE NAME VERSION */ /* */ /* hi_defs.h Nucleus PLUS 1.14 */ /* */ /* COMPONENT */ /* */ /* HI - History Management */ /* */ /* DESCRIPTION */ /* */ /* This file contains data structure definitions and constants for */ /* the History Management component. */ /* */ /* DATA STRUCTURES */ /* */ /* HI_HISTORY_ENTRY Entry in the history table */ /* */ /* FUNCTIONS */ /* */ /* None */ /* */ /* DEPENDENCIES */ /* */ /* tc_defs.h Thread Control definitions */ /* */ /* HISTORY */ /* */ /* DATE REMARKS */ /* */ /* 03-01-1993 Created initial version 1.0 */ /* 04-19-1993 Verified version 1.0 */ /* 03-01-1994 Moved include files outside of */ /* the file #ifndef to allow the */ /* use of actual data structures, */ /* resulting in version 1.1 */ /* */ /* 03-18-1994 Verified version 1.1 */ /* 04-17-1996 updated to version 1.2 */ /* 03-24-1998 Released version 1.3 */ /* 03-26-1999 Released 1.11m (new release */ /* numbering scheme) */ /* 04-17-2002 Released version 1.13m */ /* 11-07-2002 Released version 1.14 */ /*************************************************************************/ #include "tc_defs.h" /* Thread control constants */ /* Check to see if the file has been included already. */ #ifndef HI_DEFS #define HI_DEFS /* Define constants local to this component. */ #define HI_MAX_ENTRIES 30 #define HI_TASK 1 #define HI_HISR 2 #define HI_INITIALIZE 3 /* Define the History Entry data type. */ typedef struct HI_HISTORY_ENTRY_STRUCT { DATA_ELEMENT hi_id; /* ID of the history entry */ DATA_ELEMENT hi_caller; /* Task, HISR, or Initialize*/ UNSIGNED hi_param1; /* First parameter */ UNSIGNED hi_param2; /* Second parameter */ UNSIGNED hi_param3; /* Third parameter */ UNSIGNED hi_time; /* Clock tick time for entry*/ VOID *hi_thread; /* Calling thread's pointer */ } HI_HISTORY_ENTRY; #endif