FreeCalypso > hg > fc-tourmaline
view src/ui/atb/ATBPbFS.h @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | 67bfe9f274f6 |
| children |
line wrap: on
line source
/********************************************* * PB_RECS_PER_FILE * * Specifies how many records should be stored in * each file on the flash. *********************************************/ #define PB_RECS_PER_FILE 10 /********************************************* * PB_xxx_UPPER_LIMIT * * The absolute maximum size of various aspects * of the records stored on the file system. Used * to keep values read in from file within a * sensible range. *********************************************/ #define PB_RECORDS_UPPER_LIMIT 500 #define PB_ALPHATAG_UPPER_LIMIT 500 #define PB_NUMBER_UPPER_LIMIT 500 #define PB_EXT_UPPER_LIMIT 500 /********************************************** * T_PB_FSDATA * * Internal information for FS *********************************************/ typedef struct { SHORT records_max; SHORT alpha_max; SHORT number_max; SHORT ext_max; SHORT record_size; T_FFS_FD info_file; SHORT fileID; T_FFS_FD file; } T_PB_FSDATA; /********************************************** * T_PB_FSINFO * * Information about phonebook - * e.g. is SIM or FFS selected ? *********************************************/ typedef struct { UBYTE type_selected; /* The current selected phonebook */ SHORT records_max; SHORT alpha_max; SHORT number_max; SHORT ext_max; } T_PB_FSINFO; /********************************************** * LOCAL FUNCTION PROTOTYPES * *********************************************/ void FS_file_GetIndex(SHORT phys_index, SHORT *fileIndex, SHORT *recIndex); void FS_file_GetName(char *filename, SHORT phonebook_id, SHORT fileIndex); SHORT FS_file_OpenForRec(SHORT phonebook_id, SHORT phys_index);