FreeCalypso > hg > fc-tourmaline
view src/ui/mfw/mfw_acie.c @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | 67bfe9f274f6 |
children | 92abb46dc1ba |
line wrap: on
line source
/* +--------------------------------------------------------------------+ | PROJECT: MMI-Framework (8417) $Workfile:: mfw_acie.c $| | $Author:: Es $Revision:: 1 $| | CREATED: 26.10.98 $Modtime:: 2.03.00 15:25 $| | STATE : code | +--------------------------------------------------------------------+ MODULE : MFW_ACIE PURPOSE : This modul contains ACI external functions. $History:: mfw_acie.c $ * * ***************** Version 8 ***************** * User: Es Date: 2.03.00 Time: 16:04 * Updated in $/GSM/Condat/MS/SRC/MFW * some cleanups * * ***************** Version 7 ***************** * User: Vo Date: 12.02.99 Time: 18:59 * Updated in $/GSM/DEV/MS/SRC/MFW * * ***************** Version 6 ***************** * User: Es Date: 8.12.98 Time: 16:53 * Updated in $/GSM/DEV/MS/SRC/MFW * * ***************** Version 5 ***************** * User: Vo Date: 24.11.98 Time: 21:40 * Updated in $/GSM/DEV/MS/SRC/MFW * first successful compilation of MFW | | ***************** Version 4 ***************** | User: Le Date: 11.11.98 Time: 13:35 | Updated in $/GSM/DEV/MS/SRC/MFW | | ***************** Version 3 ***************** | User: Le Date: 10.11.98 Time: 16:07 | Updated in $/GSM/DEV/MS/SRC/MFW | | ***************** Version 2 ***************** | User: Le Date: 10.11.98 Time: 11:08 | Updated in $/GSM/DEV/MS/SRC/MFW | | ***************** Version 1 ***************** | User: Le Date: 27.10.98 Time: 15:58 | Created in $/GSM/DEV/MS/SRC/MFW | first implementation */ #define ENTITY_MFW #if defined (NEW_FRAME) #include "typedefs.h" #include "vsi.h" #include "custom.h" #include "gsm.h" #else #include "STDDEFS.H" #include "custom.h" #include "gsm.h" #include "vsi.h" #endif #ifdef BT_INTERFACE #include "Bti.h" #include "mfw_mfw.h" #include "mfw_bt.h" #endif #include "mfw_acie.h" #include <string.h> T_MFW_ACI_EXT aci_ext_handler [MAX_ACI_HANDLER]; #ifdef BT_INTERFACE int pSlotBt = 0; #endif /* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_ACIE | | STATE : code ROUTINE: aci_ext_init | +--------------------------------------------------------------------+ PURPOSE : */ void aci_ext_init() { UBYTE i; TRACE_FUNCTION ("aci_ext_init()"); for (i=0;i<MAX_ACI_HANDLER;i++) { aci_ext_handler[i].prim_handler = NULL; aci_ext_handler[i].cmd_handler = NULL; } } /* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_ACIE | | STATE : code ROUTINE: aci_create | +--------------------------------------------------------------------+ PURPOSE : */ GLOBAL int aci_create(T_PRIM_HANDLER prim_func, T_CMD_HANDLER cmd_func) { UBYTE i; TRACE_FUNCTION ("aci_create()"); /* changes to resolve the BUG OMAPS00064964, checking wether the * callbacks are registered twice. */ for (i=0;i<MAX_ACI_HANDLER;i++) { if(aci_ext_handler[i].prim_handler EQ prim_func AND aci_ext_handler[i].cmd_handler EQ cmd_func) { return i; } } for (i=0;i<MAX_ACI_HANDLER;i++) { if (aci_ext_handler[i].prim_handler EQ NULL AND aci_ext_handler[i].cmd_handler EQ NULL) { /* * empty entry */ aci_ext_handler[i].prim_handler = prim_func; aci_ext_handler[i].cmd_handler = cmd_func; return i; } } return -1; } /* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_ACIE | | STATE : code ROUTINE: aci_delete | +--------------------------------------------------------------------+ PURPOSE : */ GLOBAL void aci_delete(int handle) { TRACE_FUNCTION ("aci_delete ()"); if (handle >= 0 AND handle < MAX_ACI_HANDLER) { aci_ext_handler[handle].prim_handler = NULL; aci_ext_handler[handle].cmd_handler = NULL; } } /* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_ACIE | | STATE : code ROUTINE: aci_check_primitive | +--------------------------------------------------------------------+ PURPOSE : */ GLOBAL BOOL aci_check_primitive(ULONG opc, void * data) { UBYTE i; TRACE_FUNCTION ("aci_check_primitive()"); for (i=0;i<MAX_ACI_HANDLER;i++) { if (aci_ext_handler[i].prim_handler NEQ NULL) { /* * extension handler is installed; pass 32 bit opcode to primitive * handling function; note that the MFW functions are similar to pei_primitive * of aci_pei.c and as a loop is used and thus any primitive is parsed, the casting * to 32 bit opcodes needs to be performed inside those handling functions * which handle still 16bit SAPs */ if (aci_ext_handler[i].prim_handler(opc, data)) /* * primitive is processed by the extension */ return TRUE; } } #ifdef _SIMULATION_ #ifdef BT_INTERFACE if(!pSlotBt) { TRACE_EVENT_P1 ("mfw_acie:pSlotBt = %d",pSlotBt); bt_init(); } #endif #endif /* * primitive is not processed by the extension */ return FALSE; } /* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_ACIE | | STATE : code ROUTINE: aci_check_command | +--------------------------------------------------------------------+ PURPOSE : */ GLOBAL BOOL aci_check_command(char * cmd) { UBYTE i; TRACE_FUNCTION ("aci_check_command()"); for (i=0;i<MAX_ACI_HANDLER;i++) { if (aci_ext_handler[i].cmd_handler NEQ NULL) { /* * extension handler is installed */ if ((*aci_ext_handler[i].cmd_handler) (cmd)) /* * command is processed by the extension */ return TRUE; } } /* * command is not processed by the extension */ return FALSE; }