FreeCalypso > hg > fc-tourmaline
view src/ui/mfw/mfw_band.c @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | 67bfe9f274f6 |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW $Workfile:: Mfw_band.c $| | $Author:: MC/SH $Revision:: 1 $| | STATE : code | +--------------------------------------------------------------------+ MODULE : MFW_BAND PURPOSE : AT%BAND functionality for MFW $History: Mfw_band.c $ */ #define ENTITY_MFW #include <string.h> #include <stdio.h> #include <stdlib.h> #include "typedefs.h" #include "vsi.h" #include "pei.h" #include "custom.h" #include "gsm.h" #include "prim.h" #ifndef PCM_2_FFS #include "pcm.h" #endif /* BEGIN ADD: Sumit : Req ID: : 31-Mar-2005*/ #ifndef NEPTUNE_BOARD /* END ADD: Sumit : Req ID: : 31-Mar-2005*/ #include "ffs/ffs.h" /* BEGIN ADD: Sumit : Req ID: : 31-Mar-2005*/ #else #include "ffs.h" #endif /* END ADD: Sumit : Req ID: : 31-Mar-2005*/ /* SPR#1470 - SH - these includes are now outside of * FAX_AND_DATA switch */ #include "message.h" #include "prim.h" #include "aci_cmh.h" #if defined (FAX_AND_DATA) /*#include "message.h" #include "prim.h" #include "aci_cmh.h" SPR#1470 - SH */ #include "aci_fd.h" #endif #ifdef GPRS #include "gprs.h" #endif #include "dti_conn_mng.h" #include "phb.h" #include "psa.h" #include "cmh.h" #include "cmh_phb.h" #include "psa.h" #include "psa_sim.h" #include "cus_aci.h" #include "cmh_mm.h" #include "cmh_sim.h" #include "Mfw_band.h" /* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_BAND | | STATE : code ROUTINE: band_radio_mode_switch| +--------------------------------------------------------------------+ PURPOSE : Set radio band and mode */ T_MFW_BAND_RET band_radio_mode_switch(T_MFW_BAND_MODE mode, UBYTE band) { T_ACI_RETURN ret; TRACE_FUNCTION("band_radio_mode_switch"); /*a0393213 compiler warnings removal - explicit typecasting done*/ ret = sAT_PercentBAND(CMD_SRC_LCL, (T_ACI_BAND_MODE)mode, band); /*radio mode set without errors*/ TRACE_EVENT_P1("Band: %d", band); TRACE_EVENT_P1("Return val: %d", ret); switch(ret) { case (AT_BUSY): return MFW_BAND_Busy; // break; // RAVI case (AT_FAIL): return MFW_BAND_Fail; // break; // RAVI case (AT_CMPL): return MFW_BAND_OK; // break; // RAVI case (AT_EXCT): return MFW_BAND_InProgress; // break; // RAVI default: return MFW_BAND_Fail; // break; // RAVI } } /* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_BAND | | STATE : code ROUTINE: band_get_radio_modes | +--------------------------------------------------------------------+ PURPOSE : Get list of possible bands */ T_MFW_BAND_RET band_get_radio_modes(T_MFW_BAND_MODE* maxMode, UBYTE *band) { T_ACI_RETURN ret; ret = tAT_PercentBAND(CMD_SRC_LCL, (T_ACI_BAND_MODE*)maxMode, (UBYTE*)band); if (ret == AT_CMPL) return MFW_BAND_OK; else return MFW_BAND_Fail; } /* +--------------------------------------------------------------------------+ | PROJECT: GSM-MFW (8417) MODULE: MFW_BAND | | STATE : code ROUTINE: band_get_current_radio_mode | +---------------------------------------------------------------------------+ PURPOSE : Get current band setting */ T_MFW_BAND_RET band_get_current_radio_mode(T_MFW_BAND_MODE* mode, UBYTE* band) { T_ACI_RETURN ret; ret = qAT_PercentBAND(CMD_SRC_LCL, (T_ACI_BAND_MODE*)mode, (UBYTE*)band); if (ret == AT_CMPL) return MFW_BAND_OK; else return MFW_BAND_Fail; }