view src/ui/mfw/mfw_nma.h @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents 67bfe9f274f6
children 92abb46dc1ba
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: GSM-MFW (?)                  $Workfile:: mfw_nma.h       $|
| $Author:: Es                          $Revision::  1              $|
| CREATED: 14.10.98                     $Modtime:: 17.05.99 14:17   $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

	PURPOSE :  Types definitions for MMI framework 
    .
*/

#ifndef DEF_MFW_NMA_HEADER
#define DEF_MFW_NMA_HEADER

/* #include "phb.h" RSA 20/12/01 - Removed */
#include"mfw_phb.h" //RSA 20/12/01 - Added

EXTERN void nma_init (void);
EXTERN BOOL nma_response_cb (ULONG opc, void * data);

EXTERN void sAT_PlusCOPSF(UBYTE ** forbidden_id, UBYTE ** fieldstrength);
#ifdef NO_ASCIIZ
EXTERN void sAT_PlusCOPSE(UBYTE *oper, UBYTE format, 
                          T_MFW_LNAME *long_name,
                          T_MFW_SNAME *short_name, 
                          UBYTE *numeric_name);
#else
EXTERN void sAT_PlusCOPSE(UBYTE *oper, UBYTE format, UBYTE *long_name, 
                          UBYTE *short_name, UBYTE *numeric_name);
#endif

#ifdef FF_2TO1_PS
EXTERN T_CAUSE_ps_cause sAT_PlusCREGE (void);
EXTERN void  nm_nitz_info_ind(T_MMREG_INFO_IND * mmr_info_ind);
#else
EXTERN USHORT sAT_PlusCREGE (void);
EXTERN void  nm_nitz_info_ind(T_MMR_INFO_IND * mmr_info_ind);
#endif

#endif