view src/ui/mfw/mfw_phbi.h @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents 67bfe9f274f6
children 92abb46dc1ba
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT:  GSM-MFW (8417)              $Workfile:: mfw_phbi.h       $|
| $Author:: Vo                          $Revision::  1              $|
| CREATED:  7.1.99                      $Modtime:: 12.01.00 11:26   $|
| STATE  :  code                                                     |
+--------------------------------------------------------------------+

	PURPOSE :  Internal types defination for phonebook management
    . 
*/ 

#ifndef DEF_MFW_PHBI
#define DEF_MFW_PHBI

/*
 *  PHB Control Block
 */
typedef struct
{
    T_MFW_EVENT     emask;          /* events of interest */
    T_MFW_EVENT     event;          /* current event */
    T_MFW_CB        handler;
    T_MFW_PHB_PARA  para;
} T_MFW_PHB;

EXTERN BOOL     phb_sign_exec            (T_MFW_HDR * hdr,
                                          T_MFW_EVENT event, 
                                          T_MFW_PHB_PARA *para);
EXTERN void     phb_ok_clck              (void);
EXTERN void     phb_error_clck           (void);
EXTERN T_MFW_PHB_TON phb_cvtTon          (T_ACI_TOA_TON ton);
EXTERN T_MFW_PHB_NPI phb_cvtNpi          (T_ACI_TOA_NPI npi);/*a0393213 warnings removal-return type changed from T_MFW_PHB_TON*/
EXTERN T_ACI_TOA_TON phb_ncvtTon         (T_MFW_PHB_TON ton);
EXTERN T_ACI_TOA_NPI phb_ncvtNpi         (T_MFW_PHB_NPI npi);/*a0393213 warnings removal-argument type changed from T_MFW_PHB_TON*/
EXTERN void     phb_read_upn_eeprom      (void);

#endif