FreeCalypso > hg > fc-tourmaline
view src/cs/services/fcbm/fcbm_display_ctrl.c @ 268:f2e52cab0a73
abb_inth.c: check all interrupt causes, not just one
The original code used if - else if - else if etc constructs, thus
the first detected interrupt was the only one handled. However,
Iota ITSTATREG is a clear-on-read register, thus if we only handle
the first detected interrupt and skip checking the others, then the
other interrupts will be lost, if more than one interrupt happened
to occur in one ABB interrupt handling cycle - a form of rare race
condition. Change the code to check all interrupts that were read
in this cycle.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 13 Jun 2021 18:17:53 +0000 |
| parents | 35474f3a1782 |
| children |
line wrap: on
line source
/* * In this module we are going to implement our functions * for controlling display on/off state during charging boot mode. */ #include "rv/rv_general.h" #include "rvf/rvf_api.h" #include "rvm/rvm_use_id_list.h" #include "fcbm/fcbm_func_i.h" #include "fcbm/fcbm_timer_i.h" #include "fcbm/fcbm_life_cycle.h" #include "kpd/kpd_api.h" #include "r2d/r2d_blrr_api.h" void fcbm_display_off_timer(void) { if (fcbm_life_cycle_state != FCBM_STATE_ACTIVE) { rvf_send_trace("FCBM display off timer in wrong state", 37, fcbm_life_cycle_state, RV_TRACE_LEVEL_WARNING, FCBM_USE_ID); return; } blrr_display_ctrl(BLRR_DISPLAY_OFF); } void fcbm_process_kpd_msg(T_KPD_KEY_EVENT_MSG *msg) { if (fcbm_life_cycle_state != FCBM_STATE_ACTIVE) { rvf_send_trace("FCBM keypad message in wrong state", 34, fcbm_life_cycle_state, RV_TRACE_LEVEL_WARNING, FCBM_USE_ID); return; } switch (msg->key_info.state) { case KPD_KEY_PRESSED: rvf_stop_timer(FCBM_TIMER_DSPL_OFF); blrr_display_ctrl(BLRR_DISPLAY_CHG_BOOT); return; case KPD_KEY_RELEASED: rvf_start_timer(FCBM_TIMER_DSPL_OFF, RVF_SECS_TO_TICKS(FCBM_DISPLAY_SECS), FALSE); return; } }
