view src/g23m-fad/ppp/ppp_onaf.c @ 303:f76436d19a7a default tip

!GPRS config: fix long-standing AT+COPS chance hanging bug There has been a long-standing bug in FreeCalypso going back years: sometimes in the AT command bring-up sequence of an ACI-only MS, the AT+COPS command would produce only a power scan followed by cessation of protocol stack activity (only L1 ADC traces), instead of the expected network search sequence. This behaviour was seen in different FC firmware versions going back to Citrine, and seemed to follow some law of chance, not reliably repeatable. This bug has been tracked down and found to be specific to !GPRS configuration, stemming from our TCS2/TCS3 hybrid and reconstruction of !GPRS support that was bitrotten in TCS3.2/LoCosto version. ACI module psa_mms.c, needed only for !GPRS, was missing in the TCS3 version and had to be pulled from TCS2 - but as it turns out, there is a new field in the MMR_REG_REQ primitive that needs to be set correctly, and that psa_mms.c module is the place where this initialization needed to be added.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 08 Jun 2023 08:23:37 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This modul is part of the entity PPP and implements all 
|             procedures and functions as described in the 
|             SDL-documentation (ONA-statemachine)
+----------------------------------------------------------------------------- 
*/ 

#ifndef PPP_ONAF_C
#define PPP_ONAF_C
#endif /* !PPP_ONAF_C */

#define ENTITY_PPP

/*==== INCLUDES =============================================================*/

#include "typedefs.h"   /* to get Condat data types */
#include "vsi.h"        /* to get a lot of macros */
#include "macdef.h"     /* to get a lot of macros */
#include "custom.h"     /* to get a lot of macros */
#include "gsm.h"        /* to get a lot of macros */
#include "cnf_ppp.h"    /* to get cnf-definitions */
#include "mon_ppp.h"    /* to get mon-definitions */
#include "prim.h"       /* to get the definitions of used SAP and directions */
#include "dti.h"        /* to get the DTILIB definitions */
#include "ppp.h"        /* to get the global entity definitions */

/*==== CONST ================================================================*/

/*==== LOCAL VARS ===========================================================*/

/*==== PRIVATE FUNCTIONS ====================================================*/

/*==== PUBLIC FUNCTIONS =====================================================*/



/*
+------------------------------------------------------------------------------
| Function    : ona_init
+------------------------------------------------------------------------------
| Description : The function ona_init() initializes the option negotiation
|               automaton (ONA) 
|
| Parameters  : no parameters
|
+------------------------------------------------------------------------------
*/
GLOBAL void ona_init ()
{
  UBYTE i;

  TRACE_FUNCTION( "ona_init" );

  for (i = 0;i < ONA_NUM_INC;i++)
  {
    ppp_data->ona = & ppp_data->ona_base[i];

    /* counter for Configure-Request and Terminate-Request sent 	*/
    ppp_data->ona->restarts = 0;		
    /* counter for Configure-Nak and Configure-Reject sent		*/
    ppp_data->ona->failures = 0;		
    /*
     * counter for Configure-Ack received
     * this counter avoids endless loops where the PPP peer always answers with
     * a Configure-Ack, but it does not send a Configure-Req
     */
    ppp_data->ona->loops = 0;

    INIT_STATE( PPP_SERVICE_ONA , ONA_CLOSED );
  }
} /* ona_init() */


/*
+------------------------------------------------------------------------------
| Function    : ona_get_inst_index
+------------------------------------------------------------------------------
| Description : gets the index (0, 1) for the given ptype (DTI_PID_LCP, 
| DTI_PID_IPCP). This function is used when a calling service serves a key for 
| one of the 2 possible instances of services LCR and NCR.
|
| Parameters  : USHORT ptype, UBYTE* index
|
+------------------------------------------------------------------------------
*/
GLOBAL void ona_get_inst_index(USHORT ptype,
                                 UBYTE* index)
{
  TRACE_FUNCTION("ona_get_inst_index");

  if (ptype EQ DTI_PID_LCP) 
  {
    *index = 0;
  } 
  else if (ptype EQ DTI_PID_IPCP) 
  {
    *index = 1;
  } 
  else 
  {
    TRACE_ERROR( "ONA_GET_INST_INDEX unexpected ptype" );
    *index = 0;
  }
}