# HG changeset patch # User Mychaela Falconia # Date 1621235916 0 # Node ID e57bfdadf49abda6e3d2b22bf2397568b5068213 # Parent 00107c0b8570c78a5d2efc1b81c6293c0c9b8b51 mmiIcons.c: fix bogus icnType in incoming_call_animate[] The incoming call animation icons are actually drawn in 256-color format, but they were incorrectly declared as BMP_FORMAT_32BIT_COLOUR in the incoming_call_animate[] array. Why were they still getting displayed correctly despite this bogosity? Answer: because the mmi_dialogs_animation_new_CB() function overrides the icon bitmap type to 0x02, which means 256-color format. Needless to say, the icon format should be made correct at the source of the data, and at some later point we may need to remove the override from the animation display function. diff -r 00107c0b8570 -r e57bfdadf49a src/ui/bmi/mmiIcons.c --- a/src/ui/bmi/mmiIcons.c Fri May 14 06:01:34 2021 +0000 +++ b/src/ui/bmi/mmiIcons.c Mon May 17 07:18:36 2021 +0000 @@ -1786,10 +1786,10 @@ #ifdef COLOURDISPLAY const MfwIcnAttr incoming_call_animate [CALLANIMATION] = { - {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation1}, - {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation2}, - {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation3}, - {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_32BIT_COLOUR, (char *)callAnimation2} + {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation1}, + {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation2}, + {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation3}, + {{40,5,100,80},1,COLOUR_ICON_XX,BMP_FORMAT_256_COLOUR, (char *)callAnimation2} };