FreeCalypso > hg > freecalypso-sw
comparison gsm-fw/L1/include/l1_confg.h @ 714:58bbee73c4b7
gsm-fw/L1/include/l1_confg.h: SEND_FN_TO_L2_IN_DCCH fix
author | Michael Spacefalcon <msokolov@ivan.Harhan.ORG> |
---|---|
date | Fri, 03 Oct 2014 06:49:23 +0000 |
parents | eb3fb4d0dcf0 |
children | cc9d97d0e911 |
comparison
equal
deleted
inserted
replaced
713:c0d95c32a99a | 714:58bbee73c4b7 |
---|---|
1127 #define PATCH_DSP_DWNLD 3 | 1127 #define PATCH_DSP_DWNLD 3 |
1128 | 1128 |
1129 // MAC-S status reporting to Layer 1 | 1129 // MAC-S status reporting to Layer 1 |
1130 #define MACS_STATUS 0 // MAC-S STATUS activated if set to 1 | 1130 #define MACS_STATUS 0 // MAC-S STATUS activated if set to 1 |
1131 | 1131 |
1132 // Possible choice for dll_dcch_downlink interface (with FN or without FN) | 1132 /* |
1133 #define SEND_FN_TO_L2_IN_DCCH 0 | 1133 * Possible choice for dll_dcch_downlink interface (with FN or without FN) |
1134 * 0=without, 1=with FN parameter | |
1135 * | |
1136 * FreeCalypso note: the Leonardo version had this setting set to 1, i.e., | |
1137 * 3 arguments to dll_dcch_downlink(). We don't have any source or even | |
1138 * header files for the Leonardo version of DL, but disassembly shows | |
1139 * that dll_dcch_downlink() does expect the FN parameter. The source for | |
1140 * DL from LoCosto also has a SEND_FN_TO_L2_IN_DCCH configurable setting, | |
1141 * and it is set to 1 in the dl.h local header. But here is the kicker: | |
1142 * the LoCosto version of this l1_confg.h header has the setting set to 0! | |
1143 * | |
1144 * I couldn't believe my eyes, so I disassembled the binary objects present | |
1145 * in the copy of the LoCosto source from scottn.us: yes, indeed that | |
1146 * code version contains an outright bug in that L1 does not pass the | |
1147 * 3rd argument (in ARM register r2), but DL expects it to be there. | |
1148 * (Thus DL is getting whatever "garbage" happens to be in r2 as the FN | |
1149 * parameter. I did not take the time to investigate what the downstream | |
1150 * effects are.) | |
1151 * | |
1152 * For FreeCalypso I'm setting SEND_FN_TO_L2_IN_DCCH to 1, both here | |
1153 * in L1 and in DL, where it was already set. | |
1154 */ | |
1155 #define SEND_FN_TO_L2_IN_DCCH 1 | |
1134 | 1156 |
1135 /* | 1157 /* |
1136 * FreeCalypso change: I'm disabling L1_CHECK_COMPATIBLE (a new "feature" | 1158 * FreeCalypso change: I'm disabling L1_CHECK_COMPATIBLE (a new "feature" |
1137 * added with LoCosto version of L1, not present in the Leonardo version) | 1159 * added with LoCosto version of L1, not present in the Leonardo version) |
1138 * because l1_async.c fails to compile with it enabled. Examination of | 1160 * because l1_async.c fails to compile with it enabled. Examination of |