# HG changeset patch # User Michael Spacefalcon # Date 1372051459 0 # Node ID 10996c267de48627f4bd7ebd79e039e3c2fa0c8f # Parent d98137625c0d53c32827b7e008d8c14d38304ba8 loadtools old buglet: off by 1 error in the max-arguments logic in cmd parsing diff -r d98137625c0d -r 10996c267de4 loadtools/initscript.c --- a/loadtools/initscript.c Sun Jun 23 20:50:41 2013 +0000 +++ b/loadtools/initscript.c Mon Jun 24 05:24:19 2013 +0000 @@ -69,7 +69,7 @@ cp++; if (!*cp || *cp == '#') break; - if (ap - argv - 1 > tp->maxargs) { + if (ap - argv - 1 >= tp->maxargs) { fprintf(stderr, "error: too many arguments\n"); return(-1); } diff -r d98137625c0d -r 10996c267de4 loadtools/ltdispatch.c --- a/loadtools/ltdispatch.c Sun Jun 23 20:50:41 2013 +0000 +++ b/loadtools/ltdispatch.c Mon Jun 24 05:24:19 2013 +0000 @@ -69,7 +69,7 @@ cp++; if (!*cp || *cp == '#') break; - if (ap - argv - 1 > tp->maxargs) { + if (ap - argv - 1 >= tp->maxargs) { fprintf(stderr, "error: too many arguments\n"); return(-1); }