annotate libserial-newlnx/baudtab.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents ab8410d06ca7
children 6bb41b4d39ed
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
254
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This module contains the table of baud rates supported
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * by this implementation of FreeCalypso libserial.
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 */
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <stdio.h>
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include <stdlib.h>
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include <string.h>
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #include <strings.h>
255
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
10 #include <asm/termbits.h>
254
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 #include "baudrate.h"
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 struct baudrate baud_rate_table[] = {
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 /* the first listed rate will be our default */
255
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
15 {"115200", B115200, 0, 0},
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
16 {"57600", B57600, 0, 1},
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
17 {"38400", B38400, 0, 2},
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
18 {"19200", B19200, 0, 4},
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
19 /* Non-standard high baud rates */
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
20 {"812500", BOTHER, 812500, -1},
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
21 {"406250", BOTHER, 406250, -1},
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
22 {"203125", BOTHER, 203125, -1},
254
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 /* table search terminator */
255
ab8410d06ca7 libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 254
diff changeset
24 {NULL, B0, 0, -1},
254
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 };
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 struct baudrate *
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 find_baudrate_by_name(srch_name)
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 char *srch_name;
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 {
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 struct baudrate *br;
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 for (br = baud_rate_table; br->name; br++)
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 if (!strcmp(br->name, srch_name))
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 break;
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 if (br->name)
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 return(br);
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 else {
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 fprintf(stderr, "error: baud rate \"%s\" not known\n",
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 srch_name);
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 return(NULL);
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 }
6984b76f3def beginning of libserial-newlnx: copy of libserial-orig
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 }