annotate rvinterf/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents 67d683a87b1d
children 8f3fe2d1fda5
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
347
dd5bab5156bf rvinterf/Makefile: rvtat added
Mychaela Falconia <falcon@freecalypso.org>
parents: 221
diff changeset
1 PROGDIR=asyncshell ctracedec etmsync lowlevel rvtat tmsh
419
67d683a87b1d rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents: 347
diff changeset
2 LIBDIR= libasync libg23 libinterf
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 SUBDIR= ${PROGDIR} ${LIBDIR}
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
221
a46a68500517 rvinterf/Makefile: install include files in /opt/freecalypso/include/rvinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 0
diff changeset
5 INCLUDE_INSTALL_DIR= /opt/freecalypso/include/rvinterf
a46a68500517 rvinterf/Makefile: install include files in /opt/freecalypso/include/rvinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 0
diff changeset
6
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 all: ${SUBDIR}
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
419
67d683a87b1d rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents: 347
diff changeset
9 asyncshell: libasync libg23 libinterf
67d683a87b1d rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents: 347
diff changeset
10 etmsync: libinterf
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 lowlevel: libg23
419
67d683a87b1d rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents: 347
diff changeset
12 rvtat: libinterf
67d683a87b1d rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents: 347
diff changeset
13 tmsh: libasync libinterf
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 ${SUBDIR}: FRC
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 cd $@; ${MAKE} ${MFLAGS}
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 clean: FRC
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 rm -f a.out core errs
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 for i in ${SUBDIR}; do (cd $$i; ${MAKE} ${MFLAGS} clean); done
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 install: FRC
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 for i in ${PROGDIR}; do (cd $$i; ${MAKE} ${MFLAGS} install); done
221
a46a68500517 rvinterf/Makefile: install include files in /opt/freecalypso/include/rvinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 0
diff changeset
24 mkdir -p ${INCLUDE_INSTALL_DIR}
a46a68500517 rvinterf/Makefile: install include files in /opt/freecalypso/include/rvinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 0
diff changeset
25 install -c -m 644 include/* ${INCLUDE_INSTALL_DIR}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 FRC: