annotate rvinterf/etmsync/hostmkdir.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents d332fbf5c145
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
276
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * host_mkdir() function has been factored out into this module.
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 */
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 #include <sys/types.h>
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <sys/stat.h>
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include <stdio.h>
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include <stdlib.h>
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #include <unistd.h>
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 #include "exitcodes.h"
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 host_mkdir(pathname)
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 char *pathname;
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 {
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 int rc;
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 struct stat st;
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 rc = stat(pathname, &st);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 if (rc < 0) {
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 rc = mkdir(pathname, 0777);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 if (rc < 0) {
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 perror(pathname);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 return(ERROR_UNIX);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 }
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 return(0);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 } else {
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 if (S_ISDIR(st.st_mode))
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 return(0);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 else {
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 fprintf(stderr,
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 "error: %s already exists and is not a directory\n",
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 pathname);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 return(ERROR_UNIX);
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 }
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 }
d332fbf5c145 etmsync: host_mkdir() function factored out of fc-fsio
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 }