annotate rvinterf/etmsync/piradccal.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents 886f65760d09
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
323
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This module is linked into fc-tmsync and implements a command for
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * retrieving Pirelli's VBAT ADC calibration.
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 */
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <sys/types.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include <stdio.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include <stdlib.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #include <string.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 #include <strings.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 #include "localtypes.h"
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 #include "exitcodes.h"
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 get_pirelli_vbat_cal()
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 {
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 u_char bytes[2];
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 int a, b;
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 int rc;
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 rc = do_memory_read(0x027F06E5, bytes, 2);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 if (rc)
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 return(rc);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 a = bytes[0] | (bytes[1] << 8);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 rc = do_memory_read(0x027F06F7, bytes, 2);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if (rc)
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 return(rc);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 b = bytes[0] | (bytes[1] << 8);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 if (b >= 32768)
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 b -= 65536;
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 printf("A=%d B=%d\n", a, b);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 return(0);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 }