FreeCalypso > hg > freecalypso-tools
annotate rvinterf/etmsync/tmscmdtab.c @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 11 Feb 2019 00:00:19 +0000 |
parents | 886f65760d09 |
children | 379574e5cf5e |
rev | line source |
---|---|
269
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * fc-tmsync command dispatch table |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 */ |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 #include "cmdtab.h" |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 extern int cmd_dieid(); |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 extern int cmd_exec(); |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 extern int cmd_exit(); |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 extern int cmd_memdump(); |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 extern int cmd_omemdump(); |
274
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
12 extern int cmd_rfpr(); |
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
13 extern int cmd_rfpw(); |
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
14 extern int cmd_rftr(); |
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
15 extern int cmd_tms(); |
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
16 extern int cmd_ttr(); |
291
dd97e75620a7
fc-tmsync: ttr-all implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
290
diff
changeset
|
17 extern int cmd_ttr_all(); |
269
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 |
323
886f65760d09
fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
291
diff
changeset
|
19 extern int get_pirelli_vbat_cal(); |
269
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 extern int get_pirelli_imei(); |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 struct cmdtab cmdtab[] = { |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 {"dieid", 0, 0, cmd_dieid}, |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
24 {"exec", 1, 1, cmd_exec}, |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 {"exit", 0, 0, cmd_exit}, |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 {"memdump", 2, 2, cmd_memdump}, |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 {"omemdump", 2, 2, cmd_omemdump}, |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 {"pirelli-get-imei", 0, 0, get_pirelli_imei}, |
323
886f65760d09
fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
291
diff
changeset
|
29 {"pirelli-vbat-cal", 0, 0, get_pirelli_vbat_cal}, |
274
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
30 {"rfpr", 1, 1, cmd_rfpr}, |
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
31 {"rfpw", 2, 3, cmd_rfpw}, |
290
94234e9c843b
fc-tmsync: rftr save to file implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
274
diff
changeset
|
32 {"rftr", 1, 2, cmd_rftr}, |
274
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
33 {"tms", 1, 1, cmd_tms}, |
f22874b351b7
fc-tmsync: L1TM operation commands hooked in
Mychaela Falconia <falcon@freecalypso.org>
parents:
269
diff
changeset
|
34 {"ttr", 1, 1, cmd_ttr}, |
291
dd97e75620a7
fc-tmsync: ttr-all implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
290
diff
changeset
|
35 {"ttr-all", 1, 1, cmd_ttr_all}, |
269
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
36 {0, 0, 0, 0} |
20ed7a320b12
fc-tmsync skeleton started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
37 }; |