annotate rvinterf/lowlevel/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents 6f078c4a5506
children 90d7c360a614
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= gcc
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -O2
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 PROGS= rvtdump rvinterf tfc139
49
642da3373772 rvinterf/*/Makefile: move to /opt/freecalypso
Mychaela Falconia <falcon@freecalypso.org>
parents: 0
diff changeset
4 INSTBIN=/opt/freecalypso/bin
253
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
5 LIBS= ../../libserial/libserial.a ../libg23/libg23.a
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
253
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
7 RVTDUMP_OBJS= format.o format_fc.o output.o packetrx.o rvtdump.o
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 RVINTERF_OBJS= clientcmd.o format.o format_fc.o localsock.o logsent.o \
253
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
10 output.o packetrx.o packettx.o pktfwd.o rviflcd.o \
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 rvifmain.o
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
253
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
13 TFC139_OBJS= format.o output.o packetrx.o packettx.o tfc139.o
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 all: ${PROGS}
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
253
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
17 rvtdump: ${RVTDUMP_OBJS} ${LIBS}
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
18 ${CC} ${CFLAGS} -o $@ ${RVTDUMP_OBJS} ${LIBS}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
253
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
20 rvinterf: ${RVINTERF_OBJS} ${LIBS}
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
21 ${CC} ${CFLAGS} -o $@ ${RVINTERF_OBJS} ${LIBS}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22
253
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
23 tfc139: ${TFC139_OBJS} ${LIBS}
6f078c4a5506 rvinterf and friends converted to use libserial
Mychaela Falconia <falcon@freecalypso.org>
parents: 49
diff changeset
24 ${CC} ${CFLAGS} -o $@ ${TFC139_OBJS} ${LIBS}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 install: ${PROGS}
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 mkdir -p ${INSTBIN}
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 install -c ${PROGS} ${INSTBIN}
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 clean:
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 rm -f *.o *.out *errs ${PROGS}