annotate rvinterf/rvtat/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents ab8fb95a28da
children 1d5bd9a06781
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
346
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= gcc
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -O2 -I../include
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 PROG= fcup-rvtat
421
ab8fb95a28da rvinterf/rvtat converted to use libinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 346
diff changeset
4 OBJS= interf.o main.o
ab8fb95a28da rvinterf/rvtat converted to use libinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 346
diff changeset
5 LIBS= ../libinterf/libinterf.a
346
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 INSTBIN=/opt/freecalypso/bin
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 all: ${PROG}
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
421
ab8fb95a28da rvinterf/rvtat converted to use libinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 346
diff changeset
10 ${PROG}: ${OBJS} ${LIBS}
ab8fb95a28da rvinterf/rvtat converted to use libinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 346
diff changeset
11 ${CC} ${CFLAGS} -o $@ ${OBJS} ${LIBS}
346
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 install: ${PROG}
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 mkdir -p ${INSTBIN}
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 install -c ${PROG} ${INSTBIN}
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 clean:
99471c57155a fcup-rvtat program written, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 rm -f *.o *.out *errs ${PROG}