annotate rvinterf/tmsh/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents c1aadfcd185f
children 1d5bd9a06781
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= gcc
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -O2 -I../include
67
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
3 PROG= fc-tmsh
159
8fac4aaec230 fc-tmsh: beginning of intelligent ETM_AUDIO response handling
Mychaela Falconia <falcon@freecalypso.org>
parents: 150
diff changeset
4 OBJS= abb.o abbtm3.o audiocmd.o audioresp.o etmbasic.o ffs2.o ffs2resp.o \
8fac4aaec230 fc-tmsh: beginning of intelligent ETM_AUDIO response handling
Mychaela Falconia <falcon@freecalypso.org>
parents: 150
diff changeset
5 init.o l1cmd.o l1resp.o main.o misc.o omr.o omw.o oneshot.o pktsort.o \
287
92c982f67247 fc-tmsh converted to link with librftab
Mychaela Falconia <falcon@freecalypso.org>
parents: 159
diff changeset
6 rftablechk.o saverftab.o tmcore.o usercmd.o
422
c1aadfcd185f rvinterf client refactoring: libasync clients converted to use libinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 287
diff changeset
7 LIBS= ../libasync/libasync.a ../libinterf/libinterf.a \
c1aadfcd185f rvinterf client refactoring: libasync clients converted to use libinterf
Mychaela Falconia <falcon@freecalypso.org>
parents: 287
diff changeset
8 ../../librftab/librftab.a
67
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
9 INSTBIN=/opt/freecalypso/bin
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
67
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
11 all: ${PROG}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
67
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
13 ${PROG}: ${OBJS} ${LIBS}
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
14 ${CC} ${CFLAGS} -o $@ ${OBJS} ${LIBS}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
67
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
16 install: ${PROG}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 mkdir -p ${INSTBIN}
67
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
18 install -c ${PROG} ${INSTBIN}
0
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
e7502631a0f9 initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 clean:
67
ee04baba7b2b rvinterf/tmsh/Makefile: simpler structure like that used for fc-shell
Mychaela Falconia <falcon@freecalypso.org>
parents: 66
diff changeset
21 rm -f *.o *.out *errs ${PROG}