FreeCalypso > hg > freecalypso-tools
annotate target-utils/Makefile @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 11 Feb 2019 00:00:19 +0000 |
parents | 9b7ce2023355 |
children | bbb4f92265d2 |
rev | line source |
---|---|
460
9b7ce2023355
target-utils/Makefile: flash-boot-wa and simtest moved to installable set
Mychaela Falconia <falcon@freecalypso.org>
parents:
455
diff
changeset
|
1 INSTPROGS= buzplayer calversion compalstage c139explore flash-boot-wa \ |
9b7ce2023355
target-utils/Makefile: flash-boot-wa and simtest moved to installable set
Mychaela Falconia <falcon@freecalypso.org>
parents:
455
diff
changeset
|
2 loadagent pirexplore simtest |
9b7ce2023355
target-utils/Makefile: flash-boot-wa and simtest moved to installable set
Mychaela Falconia <falcon@freecalypso.org>
parents:
455
diff
changeset
|
3 ALLPROGS= ${INSTPROGS} c139-lldbg flash-boot-test helloapp tf-breakin |
94
cbc6bc05d494
target-utils/Makefile: libc added to the dependencies
Mychaela Falconia <falcon@freecalypso.org>
parents:
76
diff
changeset
|
4 LIBS= libbase libc libcommon libload libprintf libtiffs |
0
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 SUBDIR= ${ALLPROGS} ${LIBS} |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 |
43
647a7bdba4be
target-utils/Makefile: install c139explore and pirexplore
Mychaela Falconia <falcon@freecalypso.org>
parents:
0
diff
changeset
|
7 default: ${INSTPROGS} |
0
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 all: ${ALLPROGS} |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 |
199
5515360e2f61
target-utils/Makefile: flash-boot-test added
Mychaela Falconia <falcon@freecalypso.org>
parents:
94
diff
changeset
|
10 buzplayer: libbase libc libcommon libprintf |
5515360e2f61
target-utils/Makefile: flash-boot-test added
Mychaela Falconia <falcon@freecalypso.org>
parents:
94
diff
changeset
|
11 c139explore: libbase libc libcommon libprintf |
5515360e2f61
target-utils/Makefile: flash-boot-test added
Mychaela Falconia <falcon@freecalypso.org>
parents:
94
diff
changeset
|
12 c139-lldbg: libbase libc libcommon libprintf |
442
ba4171b2f980
target-utils/Makefile: calversion added
Mychaela Falconia <falcon@freecalypso.org>
parents:
415
diff
changeset
|
13 calversion: libbase libc libcommon libprintf |
199
5515360e2f61
target-utils/Makefile: flash-boot-test added
Mychaela Falconia <falcon@freecalypso.org>
parents:
94
diff
changeset
|
14 flash-boot-test: libbase libc libcommon libprintf |
5515360e2f61
target-utils/Makefile: flash-boot-test added
Mychaela Falconia <falcon@freecalypso.org>
parents:
94
diff
changeset
|
15 helloapp: libbase libc libcommon libprintf |
5515360e2f61
target-utils/Makefile: flash-boot-test added
Mychaela Falconia <falcon@freecalypso.org>
parents:
94
diff
changeset
|
16 loadagent: libbase libc libcommon libload libprintf |
5515360e2f61
target-utils/Makefile: flash-boot-test added
Mychaela Falconia <falcon@freecalypso.org>
parents:
94
diff
changeset
|
17 pirexplore: libbase libc libcommon libprintf libtiffs |
455
bd465e30fc05
target-utils/Makefile: simtest added as non-installable
Mychaela Falconia <falcon@freecalypso.org>
parents:
445
diff
changeset
|
18 simtest: libbase libc libcommon libprintf |
0
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 ${SUBDIR}: FRC |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 cd $@; ${MAKE} ${MFLAGS} |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 install: FRC |
43
647a7bdba4be
target-utils/Makefile: install c139explore and pirexplore
Mychaela Falconia <falcon@freecalypso.org>
parents:
0
diff
changeset
|
24 for i in ${INSTPROGS}; do (cd $$i; ${MAKE} ${MFLAGS} install); done |
0
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 clean: FRC |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 rm -f a.out core errs |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 for i in ${SUBDIR}; do \ |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
29 if [ -d $$i ]; then \ |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
30 (cd $$i; ${MAKE} ${MFLAGS} clean) \ |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
31 fi \ |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
32 done |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
33 |
e7502631a0f9
initial import from freecalypso-sw rev 1033:5ab737ac3ad7
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
34 FRC: |