annotate target-utils/buzplayer/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents 5aff772ff84d
children 58d3a0634272
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
76
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= arm-elf-gcc
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -Os -fno-builtin
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CPPFLAGS=-I../include
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 LD= arm-elf-ld
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 OBJCOPY=arm-elf-objcopy
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 INSTDIR=/opt/freecalypso/target-bin
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 PROG= buzplayer
81
8a200d65c6a0 buzplayer: play implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 80
diff changeset
10 OBJS= crt0.o cmdtab.o main.o melentry.o melplay.o mygetchar.o timer.o
98
5aff772ff84d target-utils: buzplayer converted to our own libc
Mychaela Falconia <falcon@freecalypso.org>
parents: 81
diff changeset
11 LIBS= ../libcommon/libcommon.a ../libprintf/libprintf.a ../libbase/libbase.a \
5aff772ff84d target-utils: buzplayer converted to our own libc
Mychaela Falconia <falcon@freecalypso.org>
parents: 81
diff changeset
12 ../libc/libc.a
5aff772ff84d target-utils: buzplayer converted to our own libc
Mychaela Falconia <falcon@freecalypso.org>
parents: 81
diff changeset
13 LIBGCC= `${CC} -print-file-name=libgcc.a`
76
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 LDS= ../env/iram.lds
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 all: ${PROG}.srec
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 crt0.S: ../env/crt0.S
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 ln -s $< .
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 ${PROG}.elf: ${OBJS} ${LIBS} ${LDS}
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 ${LD} -N --defsym Base_addr=0x800750 --defsym stack_bottom=0x83FFFC \
98
5aff772ff84d target-utils: buzplayer converted to our own libc
Mychaela Falconia <falcon@freecalypso.org>
parents: 81
diff changeset
23 -T ${LDS} -o $@ ${OBJS} ${LIBS} ${LIBGCC}
76
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 ${PROG}.srec: ${PROG}.elf
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 ${OBJCOPY} -O srec --srec-forceS3 --srec-len=30 $< $@
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 install:
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 mkdir -p ${INSTDIR}
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 install -c -m 644 ${PROG}.srec ${INSTDIR}
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 clean:
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 rm -f *.o *errs *core *.elf *.bin *.srec crt0.S
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34
5bbba2cab6f3 target-utils: buzplayer started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 FRC: