annotate target-utils/libc/memcmp.S @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents a675cec34076
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
93
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 .text
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 .code 32
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 .globl bcmp
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 .globl memcmp
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 bcmp:
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 memcmp:
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cmp r2, #0
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 beq zero_len_out
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 mov r3, r0
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 1: ldrb r0, [r3], #1
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 ldrb r12, [r1], #1
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 subs r0, r0, r12
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 bxne lr
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 subs r2, r2, #1
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 bne 1b
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 bx lr
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 zero_len_out:
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 mov r0, #0
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 bx lr