annotate uptools/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents b0cb465290f7
children 8f3fe2d1fda5
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
349
b0cb465290f7 uptools/Makefile: atcmd added
Mychaela Falconia <falcon@freecalypso.org>
parents: 342
diff changeset
1 PROGDIR=atcmd atinterf sms-pdu-decode
338
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 LIBDIR= libcoding
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 SUBDIR= ${PROGDIR} ${LIBDIR}
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 all: ${SUBDIR}
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
349
b0cb465290f7 uptools/Makefile: atcmd added
Mychaela Falconia <falcon@freecalypso.org>
parents: 342
diff changeset
7 atcmd: libcoding
338
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 sms-pdu-decode: libcoding
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 ${SUBDIR}: FRC
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 cd $@; ${MAKE} ${MFLAGS}
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 clean: FRC
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 rm -f a.out core errs
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 for i in ${SUBDIR}; do (cd $$i; ${MAKE} ${MFLAGS} clean); done
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 install: FRC
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 for i in ${PROGDIR}; do (cd $$i; ${MAKE} ${MFLAGS} install); done
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 FRC: