annotate uptools/libcoding/Makefile @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents f7228c18463a
children f023a1c187a9
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
328
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= gcc
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -O2
335
097ce8431d11 uptools/libcoding: SMS DCS decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 334
diff changeset
3 OBJS= alpha_addr.o decode_helpers.o grokdcs.o gsm7_decode.o \
357
15120d15cab5 uptools/libcoding: septet to octet packing function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 356
diff changeset
4 gsm7_decode_tables.o gsm7_encode.o gsm7_encode_table.o gsm7_pack.o \
361
ae2556e256a4 uptools/libcoding: implemented function for generating hex strings
Mychaela Falconia <falcon@freecalypso.org>
parents: 360
diff changeset
5 gsm7_unpack.o gsmtime.o hexdecode.o hexdump.o hexencode.o \
375
759cb6dc501b uptools/libcoding: added function for generating SMS PDUs with 8-bit text
Mychaela Falconia <falcon@freecalypso.org>
parents: 361
diff changeset
6 number_decode.o number_encode.o scaddr.o sms_submit.o sms_submit8.o \
377
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents: 376
diff changeset
7 ucs2_bigend.o ucs2_decode.o utf8_decode.o utf8_decode2.o
328
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 LIB= libcoding.a
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 all: ${LIB}
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 ${LIB}: ${OBJS}
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 ar rcu $@ ${OBJS}
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 ranlib $@
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 clean:
978571e23318 uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 rm -f *.[oa] errs