annotate uptools/libcoding/gsmtime.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents f40530e2d48d
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
334
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This library module implements decoding of GSM timestamps.
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 */
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 #include <sys/types.h>
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <stdio.h>
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 gsm_timestamp_decode(inbuf, outbuf)
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 u_char *inbuf;
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 char *outbuf;
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 {
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 u_char rev[7];
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 int i, d1, d2, tzsign;
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 for (i = 0; i < 7; i++) {
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 d1 = inbuf[i] & 0xF;
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 d2 = inbuf[i] >> 4;
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 rev[i] = (d1 << 4) | d2;
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 }
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 if (rev[6] & 0x80) {
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 rev[6] &= 0x7F;
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 tzsign = '-';
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 } else
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 tzsign = '+';
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 sprintf(outbuf, "%02X/%02X/%02X,%02X:%02X:%02X%c%02X", rev[0], rev[1],
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 rev[2], rev[3], rev[4], rev[5], tzsign, rev[6]);
f40530e2d48d uptools/libcoding: GSM timestamp decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 }