annotate uptools/libcoding/hexdump.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents ead4ee22ef62
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
336
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This library module implements a simple hex dump facility.
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 */
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 #include <sys/types.h>
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <stdio.h>
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 msg_bits_hexdump(dumpbuf, dumplen)
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 u_char *dumpbuf;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 unsigned dumplen;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 {
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 u_char *buf = dumpbuf;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 unsigned lineoff, linelen, i, c;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 for (lineoff = 0; lineoff < dumplen; ) {
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 linelen = dumplen - lineoff;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 if (linelen > 16)
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 linelen = 16;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 printf("%02X: ", lineoff);
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 for (i = 0; i < 16; i++) {
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 if (i < linelen)
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 printf("%02X ", buf[i]);
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 else
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 fputs(" ", stdout);
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if (i == 7 || i == 15)
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 putchar(' ');
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 }
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 for (i = 0; i < linelen; i++) {
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 c = buf[i];
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 if (c < ' ' || c > '~')
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 c = '.';
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 putchar(c);
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 }
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 putchar('\n');
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 buf += linelen;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 lineoff += linelen;
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 }
ead4ee22ef62 uptools/libcoding: hex dump function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 }