annotate uptools/libcoding/number_decode.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents ea41b6001848
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
331
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This library module implements the decoding of number (address) digits.
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 */
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 #include <sys/types.h>
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 char gsm_address_digits[16] =
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 {'0','1','2','3','4','5','6','7','8','9','*','#','a','b','c','?'};
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 decode_address_digits(inbuf, outbuf, ndigits)
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 u_char *inbuf;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 char *outbuf;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 unsigned ndigits;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 {
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 u_char *inp = inbuf;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 char *outp = outbuf;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 unsigned n = 0, b;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 while (n < ndigits) {
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 b = *inp++;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 *outp++ = gsm_address_digits[b & 0xF];
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 n++;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 if (n >= ndigits)
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 break;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 *outp++ = gsm_address_digits[b >> 4];
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 n++;
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 }
332
ea41b6001848 uptools/libcoding: SC address decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 331
diff changeset
28 *outp = '\0';
331
110fffa1f001 uptools/libcoding: digit decoding implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 }