annotate uptools/libcoding/ucs2_bigend.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents f7228c18463a
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
377
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This library module implements the function for converting a UCS-2
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * string from native 16-bit words into a byte buffer for SMS.
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 */
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <sys/types.h>
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 ucs2_out_bigend(inbuf, outbuf, nuni)
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 u_short *inbuf;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 u_char *outbuf;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 unsigned nuni;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 {
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 u_short *ip = inbuf;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 u_char *op = outbuf;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 unsigned n, uni;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 for (n = 0; n < nuni; n++) {
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 uni = *ip++;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 *op++ = uni >> 8;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 *op++ = uni;
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 }
f7228c18463a uptools/libcoding: added function for UCS-2 BE output
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 }