annotate target-utils/libc/memcmp.S @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents a675cec34076
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
93
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 .text
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 .code 32
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 .globl bcmp
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 .globl memcmp
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 bcmp:
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 memcmp:
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cmp r2, #0
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 beq zero_len_out
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 mov r3, r0
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 1: ldrb r0, [r3], #1
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 ldrb r12, [r1], #1
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 subs r0, r0, r12
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 bxne lr
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 subs r2, r2, #1
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 bne 1b
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 bx lr
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 zero_len_out:
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 mov r0, #0
a675cec34076 target-utils/libc: assembly implementation of bcmp/memcmp
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 bx lr