FreeCalypso > hg > freecalypso-tools
annotate target-utils/libcommon/defgetchar.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | f9d2ce6591b7 |
children |
rev | line source |
---|---|
519
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * The interactive command entry (editing) function in libcommon |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 * will call mygetchar() for its character input. It is supposed |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 * to be a blocking wait for input, but in some programs other |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 * processing can be done while waiting - for example, check for |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 * keypad presses as well. This is the basic version which waits |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 * for serial input and nothing else - specific programs can |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 * override it if necessary, but this library version is the default. |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 */ |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 extern int serial_in_poll(); |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 int |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 mygetchar() |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 { |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 register int c; |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 do |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 c = serial_in_poll(); |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 while (c < 0); |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 return c; |
f9d2ce6591b7
target-utils: default mygetchar() added to libcommon
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 } |