annotate target-utils/loadagent/serextra.S @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 3229940734e5
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
648
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 #include "ns16550.h"
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 @ extra serial I/O functions for loadagent binary operations
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 .text
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 .code 32
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 .globl serial_out_if_empty
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 serial_out_if_empty:
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 ldr r1, =uart_base
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 ldr r2, [r1]
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 ldrb r3, [r2, #NS16550_LSR]
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 tst r3, #NS16550_LSR_THRE
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 strneb r0, [r2, #NS16550_THR]
3229940734e5 loadagent: binary memload command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 bx lr