FreeCalypso > hg > freecalypso-tools
annotate target-utils/simtest/volt.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 3884d823b36e |
children |
rev | line source |
---|---|
456
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 #include <sys/types.h> |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 #include <strings.h> |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 #include "types.h" |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 #include "abbdefs.h" |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 void |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 cmd_volt(argbulk) |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 char *argbulk; |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 { |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 char *argv[2]; |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 if (parse_args(argbulk, 1, 1, argv, 0) < 0) |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 return; |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 if (!strcmp(argv[0], "1.8")) |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 abb_reg_write(VRPCSIM, 2); |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 else if (!strcmp(argv[0], "3")) |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 abb_reg_write(VRPCSIM, 3); |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 else |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 printf("ERROR: \"1.8\" or \"3\" argument expected\n"); |
3884d823b36e
simtest: volt command implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 } |