FreeCalypso > hg > freecalypso-tools
annotate uptools/libcoding/decode_helpers.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 1c599681fd60 |
children |
rev | line source |
---|---|
328
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * This library module implements the is_decoded_char_ok() and emit_utf8_char() |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 * functions used by gsm7_to_ascii_or_ext() and ucs2_to_ascii_or_ext(). |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 */ |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #include <sys/types.h> |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 is_decoded_char_ok(uni, ascii_ext) |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 unsigned uni; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 { |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 unsigned upper_limit; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 /* weed out control chars first */ |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 if (uni < 0x20) |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 return(0); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 if (uni >= 0x7F && uni <= 0x9F) |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 return(0); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 /* see what range our output encoding allows */ |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 switch (ascii_ext) { |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 case 0: |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 upper_limit = 0x7F; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 break; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 case 1: |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
24 upper_limit = 0xFF; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 break; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 case 2: |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 upper_limit = 0xFFFF; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 break; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
29 default: |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
30 upper_limit = 0; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
31 } |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
32 if (uni <= upper_limit) |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
33 return(1); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
34 else |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
35 return(0); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
36 } |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
37 |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
38 emit_utf8_char(uni, outp) |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
39 unsigned uni; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
40 u_char *outp; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
41 { |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
42 if (uni < 0x80) { |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
43 *outp = uni; |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
44 return(1); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
45 } |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
46 if (uni < 0x800) { |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
47 outp[0] = 0xC0 | (uni >> 6); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
48 outp[1] = 0x80 | (uni & 0x3F); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
49 return(2); |
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
50 } |
802
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
51 if (uni < 0x10000) { |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
52 outp[0] = 0xE0 | (uni >> 12); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
53 outp[1] = 0x80 | ((uni >> 6) & 0x3F); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
54 outp[2] = 0x80 | (uni & 0x3F); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
55 return(3); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
56 } |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
57 outp[0] = 0xF0 | (uni >> 18); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
58 outp[1] = 0x80 | ((uni >> 12) & 0x3F); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
59 outp[2] = 0x80 | ((uni >> 6) & 0x3F); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
60 outp[3] = 0x80 | (uni & 0x3F); |
1c599681fd60
pcm-sms-decode & sms-pdu-decode: revamp bad char decoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
328
diff
changeset
|
61 return(4); |
328
978571e23318
uptools started with libcoding
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
62 } |