FreeCalypso > hg > freecalypso-tools
annotate librftab/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | b73c21a2148f |
children |
rev | line source |
---|---|
281 | 1 CC= gcc |
2 CFLAGS= -O2 | |
720
b73c21a2148f
reorg: smallconv.c moved from ffstools/cal2text to librftab
Mychaela Falconia <falcon@freecalypso.org>
parents:
315
diff
changeset
|
3 OBJS= readfir.o readtxramp.o rftablerd.o rftablewr.o smallconv.o |
281 | 4 LIB= librftab.a |
5 | |
6 all: ${LIB} | |
7 | |
8 ${LIB}: ${OBJS} | |
9 ar rcu $@ ${OBJS} | |
10 ranlib $@ | |
11 | |
12 clean: | |
13 rm -f *.[oa] errs |