FreeCalypso > hg > freecalypso-tools
annotate libserial-linux/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | fd7b447b99e3 |
children |
rev | line source |
---|---|
255
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 CC= gcc |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 CFLAGS= -O2 |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 OBJS= baudtab.o nonblock.o openport.o setbaud.o setbyname.o |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 LIB= libserial.a |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 all: ${LIB} |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 ${LIB}: ${OBJS} |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 ar rcu $@ ${OBJS} |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 ranlib $@ |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 clean: |
ab8410d06ca7
libserial-newlnx: new way implemented, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 rm -f *.[oa] errs |