annotate loadtools/discontig.h @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents a880f48d6ac0
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
652
d42534e5ac02 loadtools: discontig.h split out of flash.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /* support for flashing or XRAM-loading discontiguous S-record images */
d42534e5ac02 loadtools: discontig.h split out of flash.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
655
a880f48d6ac0 loadtools: MAX_SREC_REGIONS def moved into discontig.h
Mychaela Falconia <falcon@freecalypso.org>
parents: 652
diff changeset
3 #define MAX_SREC_REGIONS 256
a880f48d6ac0 loadtools: MAX_SREC_REGIONS def moved into discontig.h
Mychaela Falconia <falcon@freecalypso.org>
parents: 652
diff changeset
4
652
d42534e5ac02 loadtools: discontig.h split out of flash.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 struct discontig_prog {
d42534e5ac02 loadtools: discontig.h split out of flash.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 uint32_t start;
d42534e5ac02 loadtools: discontig.h split out of flash.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 uint32_t end;
d42534e5ac02 loadtools: discontig.h split out of flash.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 uint32_t crc;
d42534e5ac02 loadtools: discontig.h split out of flash.h
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 };