FreeCalypso > hg > freecalypso-tools
annotate rvinterf/libinterf/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 1d5bd9a06781 |
children |
rev | line source |
---|---|
419
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 CC= gcc |
470
1d5bd9a06781
rvinterf tree Makefiles: split CPPFLAGS from CFLAGS
Mychaela Falconia <falcon@freecalypso.org>
parents:
419
diff
changeset
|
2 CFLAGS= -O2 |
1d5bd9a06781
rvinterf tree Makefiles: split CPPFLAGS from CFLAGS
Mychaela Falconia <falcon@freecalypso.org>
parents:
419
diff
changeset
|
3 CPPFLAGS=-I../include |
419
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 OBJS= connect.o launchrvif.o |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 LIB= libinterf.a |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 all: ${LIB} |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 ${LIB}: ${OBJS} |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 ar rcu $@ ${OBJS} |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 ranlib $@ |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 clean: |
67d683a87b1d
rvinterf client refactoring: libinterf created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 rm -f *.[oa] errs |