FreeCalypso > hg > freecalypso-tools
annotate target-utils/flash-boot-test/uartbase.S @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | dbb54db721d1 |
children |
rev | line source |
---|---|
197
dbb54db721d1
target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 .section .rodata |
dbb54db721d1
target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 .balign 4 |
dbb54db721d1
target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 .globl uart_base |
dbb54db721d1
target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 uart_base: |
dbb54db721d1
target-utils/flash-boot-test written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 .word 0xFFFF5000 |