FreeCalypso > hg > freecalypso-tools
annotate target-utils/simagent/main.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | f18db0f00ad8 |
children |
rev | line source |
---|---|
454
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 main() |
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 { |
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 uart_select_init(); |
769
f18db0f00ad8
target-utils: simagent application started
Mychaela Falconia <falcon@freecalypso.org>
parents:
531
diff
changeset
|
4 printf("Calypso SIM interface agent running\n"); |
454
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 print_boot_rom_info(); |
531
d36c793d71db
simtest standalone program: added abb_init() call
Mychaela Falconia <falcon@freecalypso.org>
parents:
454
diff
changeset
|
6 abb_init(); |
454
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 for (;;) { |
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 putchar('='); |
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 if (command_entry()) |
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 command_dispatch(); |
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 } |
daaab2701761
target-utils: simtest program started
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 } |