annotate uptools/Makefile @ 964:a96cb97b66a2

ringtools/imy: fix duplicate definition of tdma_durations[] The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>, although the present fix is slightly different from the contributed patch: because main.c doesn't need this tdma_durations[] array at all, let's simply remove the reference to this array from main.c rather than turn it into an extern. I no longer remember my original thought flow that resulted (by mistake) in tdma_durations[] being multiply defined in main.c and durations.c. My intent might have been to define all globals in main.c and have the reference in durations.c be an extern - and I missed that extern - but without clear memory, I have no certainty. In any case, having this data array defined in the same module that fills it (durations.c) is sensible, so let's make it the new way.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 31 Aug 2023 19:38:18 +0000
parents f2a040324509
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
471
8f3fe2d1fda5 Makefile hierarchy: allow CC and CFLAGS to be overridden from the top
Mychaela Falconia <falcon@freecalypso.org>
parents: 349
diff changeset
1 CC= gcc
8f3fe2d1fda5 Makefile hierarchy: allow CC and CFLAGS to be overridden from the top
Mychaela Falconia <falcon@freecalypso.org>
parents: 349
diff changeset
2 CFLAGS= -O2
349
b0cb465290f7 uptools/Makefile: atcmd added
Mychaela Falconia <falcon@freecalypso.org>
parents: 342
diff changeset
3 PROGDIR=atcmd atinterf sms-pdu-decode
338
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 LIBDIR= libcoding
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 SUBDIR= ${PROGDIR} ${LIBDIR}
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
473
90d7c360a614 main tree Makefile hierarchy: INSTALL_PREFIX= scheme implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 471
diff changeset
7 INSTALL_PREFIX= /opt/freecalypso
90d7c360a614 main tree Makefile hierarchy: INSTALL_PREFIX= scheme implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 471
diff changeset
8
338
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 all: ${SUBDIR}
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
349
b0cb465290f7 uptools/Makefile: atcmd added
Mychaela Falconia <falcon@freecalypso.org>
parents: 342
diff changeset
11 atcmd: libcoding
338
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 sms-pdu-decode: libcoding
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 ${SUBDIR}: FRC
479
f2a040324509 Makefile hierarchy: CFLAGS override-ability actually works now
Mychaela Falconia <falcon@freecalypso.org>
parents: 473
diff changeset
15 cd $@; ${MAKE} ${MFLAGS} CC=${CC} CFLAGS="${CFLAGS}"
338
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 clean: FRC
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 rm -f a.out core errs
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 for i in ${SUBDIR}; do (cd $$i; ${MAKE} ${MFLAGS} clean); done
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 install: FRC
473
90d7c360a614 main tree Makefile hierarchy: INSTALL_PREFIX= scheme implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 471
diff changeset
22 for i in ${PROGDIR}; do (cd $$i; ${MAKE} ${MFLAGS} \
90d7c360a614 main tree Makefile hierarchy: INSTALL_PREFIX= scheme implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 471
diff changeset
23 INSTALL_PREFIX=${INSTALL_PREFIX} install); done
338
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
97a72ec0a6c1 uptools/Makefile created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 FRC: