annotate rvinterf/etmsync/piradccal.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 886f65760d09
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
323
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * This module is linked into fc-tmsync and implements a command for
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * retrieving Pirelli's VBAT ADC calibration.
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 */
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <sys/types.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include <stdio.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include <stdlib.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #include <string.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 #include <strings.h>
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 #include "localtypes.h"
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 #include "exitcodes.h"
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 get_pirelli_vbat_cal()
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 {
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 u_char bytes[2];
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 int a, b;
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 int rc;
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 rc = do_memory_read(0x027F06E5, bytes, 2);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 if (rc)
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 return(rc);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 a = bytes[0] | (bytes[1] << 8);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 rc = do_memory_read(0x027F06F7, bytes, 2);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if (rc)
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 return(rc);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 b = bytes[0] | (bytes[1] << 8);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 if (b >= 32768)
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 b -= 65536;
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 printf("A=%d B=%d\n", a, b);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 return(0);
886f65760d09 fc-tmsync: added pirelli-vbat-cal command to read Pirelli's ADC calibration
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 }